From 8f60ec99002a1f6c5e1df33a34743e75ee78f13a Mon Sep 17 00:00:00 2001
From: ziyue <1213642868@qq.com>
Date: Wed, 1 Dec 2021 21:38:31 +0800
Subject: [PATCH] =?UTF-8?q?Refine:=20=E7=B2=BE=E7=AE=80=E5=A4=8D=E7=94=A8M?=
 =?UTF-8?q?ediaSink=E7=9B=B8=E5=85=B3=E4=BB=A3=E7=A0=81?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 src/Common/MediaSink.cpp  |  2 +-
 src/Player/PlayerBase.cpp | 85 +++++++++------------------------------
 src/Player/PlayerBase.h   | 23 ++++++++++-
 3 files changed, 42 insertions(+), 68 deletions(-)

diff --git a/src/Common/MediaSink.cpp b/src/Common/MediaSink.cpp
index f5146707..ac7b406b 100644
--- a/src/Common/MediaSink.cpp
+++ b/src/Common/MediaSink.cpp
@@ -158,7 +158,7 @@ void MediaSink::emitAllTrackReady() {
                 continue;
             }
             pr.second.for_each([&](const Frame::Ptr &frame) {
-                onTrackFrame(frame);
+                inputFrame(frame);
             });
         }
         _frame_unread.clear();
diff --git a/src/Player/PlayerBase.cpp b/src/Player/PlayerBase.cpp
index ae02d365..ddab7f3e 100644
--- a/src/Player/PlayerBase.cpp
+++ b/src/Player/PlayerBase.cpp
@@ -65,90 +65,35 @@ PlayerBase::PlayerBase() {
 
 ///////////////////////////DemuxerSink//////////////////////////////
 
-class DemuxerSink : public MediaSink {
-public:
-    DemuxerSink() = default;
-    ~DemuxerSink() override = default;
-
-    /**
-     * 设置track监听器
-     */
-    void setTrackListener(TrackListener *listener);
-    vector<Track::Ptr> getTracks(bool ready = true) const override;
-
-protected:
-    bool addTrack(const Track::Ptr & track) override;
-    void resetTracks() override;
-    bool onTrackReady(const Track::Ptr & track) override;
-    void onAllTrackReady() override;
-    bool onTrackFrame(const Frame::Ptr &frame) override;
-
-private:
-    Track::Ptr _tracks[TrackMax];
-    TrackListener *_listener = nullptr;
-};
-
-bool DemuxerSink::addTrack(const Track::Ptr &track) {
-    auto ret = MediaSink::addTrack(track);
-    if (ret) {
-        track->addDelegate(std::make_shared<FrameWriterInterfaceHelper>([this](const Frame::Ptr &frame) {
-            return inputFrame(frame);
-        }));
-    }
-    return ret;
-}
-
-void DemuxerSink::setTrackListener(TrackListener *listener) {
+void MediaSinkDelegate::setTrackListener(TrackListener *listener) {
     _listener = listener;
 }
 
-bool DemuxerSink::onTrackReady(const Track::Ptr &track) {
-    _tracks[track->getTrackType()] = track->clone();
+bool MediaSinkDelegate::onTrackReady(const Track::Ptr &track) {
+    if (_listener) {
+        _listener->addTrack(track);
+    }
     return true;
 }
 
-void DemuxerSink::onAllTrackReady() {
-    if (!_listener) {
-        return;
+void MediaSinkDelegate::onAllTrackReady() {
+    if (_listener) {
+        _listener->addTrackCompleted();
     }
-    for (auto &track : _tracks) {
-        if (track) {
-            _listener->addTrack(track);
-        }
-    }
-    _listener->addTrackCompleted();
 }
 
-bool DemuxerSink::onTrackFrame(const Frame::Ptr &frame) {
-    return _tracks[frame->getTrackType()]->inputFrame(frame);
-}
-
-void DemuxerSink::resetTracks() {
+void MediaSinkDelegate::resetTracks() {
     MediaSink::resetTracks();
-    for (auto &track : _tracks) {
-        track = nullptr;
-    }
     if (_listener) {
         _listener->resetTracks();
     }
 }
 
-vector<Track::Ptr> DemuxerSink::getTracks(bool ready) const {
-    vector<Track::Ptr> ret;
-    for (auto &track : _tracks) {
-        if (!track || (ready && !track->ready())) {
-            continue;
-        }
-        ret.emplace_back(track);
-    }
-    return ret;
-}
-
 ///////////////////////////Demuxer//////////////////////////////
 
 void Demuxer::setTrackListener(TrackListener *listener, bool wait_track_ready) {
     if (wait_track_ready) {
-        auto sink = std::make_shared<DemuxerSink>();
+        auto sink = std::make_shared<MediaSinkDelegate>();
         sink->setTrackListener(listener);
         _sink = std::move(sink);
     }
@@ -158,8 +103,16 @@ void Demuxer::setTrackListener(TrackListener *listener, bool wait_track_ready) {
 bool Demuxer::addTrack(const Track::Ptr &track) {
     if (!_sink) {
         _origin_track.emplace_back(track);
+        return _listener ? _listener->addTrack(track) : false;
     }
-    return _sink ? _sink->addTrack(track) : (_listener ? _listener->addTrack(track) : false);
+
+    if (_sink->addTrack(track)) {
+        track->addDelegate(std::make_shared<FrameWriterInterfaceHelper>([this](const Frame::Ptr &frame) {
+            return _sink->inputFrame(frame);
+        }));
+        return true;
+    }
+    return false;
 }
 
 void Demuxer::addTrackCompleted() {
diff --git a/src/Player/PlayerBase.h b/src/Player/PlayerBase.h
index a9730435..146b4dd5 100644
--- a/src/Player/PlayerBase.h
+++ b/src/Player/PlayerBase.h
@@ -238,16 +238,37 @@ protected:
     std::shared_ptr<Delegate> _delegate;
 };
 
+class MediaSinkDelegate : public MediaSink {
+public:
+    MediaSinkDelegate() = default;
+    ~MediaSinkDelegate() override = default;
+
+    /**
+     * 设置track监听器
+     */
+    void setTrackListener(TrackListener *listener);
+
+protected:
+    void resetTracks() override;
+    bool onTrackReady(const Track::Ptr & track) override;
+    void onAllTrackReady() override;
+
+private:
+    TrackListener *_listener = nullptr;
+};
+
 class Demuxer : protected TrackListener, public TrackSource {
 public:
     Demuxer() = default;
     ~Demuxer() override = default;
 
     void setTrackListener(TrackListener *listener, bool wait_track_ready = false);
+    vector<Track::Ptr> getTracks(bool trackReady = true) const override;
+
+protected:
     bool addTrack(const Track::Ptr &track) override;
     void addTrackCompleted() override;
     void resetTracks() override;
-    vector<Track::Ptr> getTracks(bool trackReady = true) const override;
 
 private:
     MediaSink::Ptr _sink;